Page MenuHomePhabricator
Differential D5815

Pass rpc/server RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 23 2020, 00:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan
rABCae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Depends on D5809

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs abcPatched
./checkrpc.sh RPCs master abcPatched abc.diff

Verify the changes in abc.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

server.diff:

server.diff671 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-server
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10364
Build 18549: Default Diff Build & Tests
Build 18548: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 23 2020, 00:31
Owners added a reviewer: Restricted Owners Package.Apr 23 2020, 00:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 00:31
nakihito planned changes to this revision.Apr 23 2020, 00:31
teamcity edited the summary of this revision. (Show Details)Apr 23 2020, 00:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 23 2020, 00:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 23 2020, 00:32
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 23 2020, 00:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10364: Diff 19049.Apr 23 2020, 00:41
Fabien accepted this revision.Apr 23 2020, 09:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/server.cpp
316

restore

This revision is now accepted and ready to land.Apr 23 2020, 09:11
nakihito updated this revision to Diff 19062.Apr 23 2020, 18:05

Restored newline.

teamcity added a comment.Apr 23 2020, 18:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 23 2020, 18:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10367: Diff 19062.Apr 23 2020, 18:15
Closed by commit rABCae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 23 2020, 19:38
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGINGae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
src/
rpc/
58 lines

Diff 19049

View Options

src/rpc/server.cpp

Loading...