Page MenuHomePhabricator
Differential D5818

Pass zmq RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 23 2020, 19:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6cc421370619: Pass zmq RPC results and examples to RPCHelpMan
rABC6cc421370619: Pass zmq RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs zmqPatched
./checkrpc.sh RPCs master zmqPatched zmq.diff

Verify zmq.diff does not exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-zmq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10369
Build 18559: Default Diff Build & Tests
Build 18558: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 23 2020, 19:47
Owners added a reviewer: Restricted Owners Package.Apr 23 2020, 19:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 19:47
nakihito planned changes to this revision.Apr 23 2020, 19:47
teamcity edited the summary of this revision. (Show Details)Apr 23 2020, 19:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 23 2020, 19:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 23 2020, 19:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10369: Diff 19067.Apr 23 2020, 19:57
nakihito requested review of this revision.Apr 23 2020, 22:34
nakihito edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Apr 23 2020, 23:37
This revision is now accepted and ready to land.Apr 23 2020, 23:37
Closed by commit rABC6cc421370619: Pass zmq RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 24 2020, 01:02
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC6cc421370619: Pass zmq RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGING6cc421370619: Pass zmq RPC results and examples to RPCHelpMan.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
src/
zmq/
35 lines

Diff 19067

View Options

src/zmq/zmqrpc.cpp

Loading...