Page MenuHomePhabricator
Differential D5822

Pass rpc/mining RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 24 2020, 01:22.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan
rABC9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched mining.diff

Verify changes in mining.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

mining.diff:

mining.diff813 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-mining
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10375
Build 18571: Default Diff Build & Tests
Build 18570: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 24 2020, 01:22
Owners added a reviewer: Restricted Owners Package.Apr 24 2020, 01:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 01:22
nakihito planned changes to this revision.Apr 24 2020, 01:22
teamcity edited the summary of this revision. (Show Details)Apr 24 2020, 01:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 24 2020, 01:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 24 2020, 01:24
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 24 2020, 01:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10375: Diff 19078.Apr 24 2020, 01:32
Fabien requested changes to this revision.Apr 24 2020, 08:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/mining.cpp
503

This block needs to be fixed, the added indent created a lot of single word lines with the continuation on next line.

This revision now requires changes to proceed.Apr 24 2020, 08:24
nakihito updated this revision to Diff 19091.Apr 24 2020, 18:09

Fixed formatting.

teamcity added a comment.Apr 24 2020, 18:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10384: Diff 19091.Apr 24 2020, 18:19
deadalnix accepted this revision.Apr 25 2020, 21:06
Fabien accepted this revision.Apr 27 2020, 09:32
This revision is now accepted and ready to land.Apr 27 2020, 09:32
Closed by commit rABC9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 27 2020, 17:51
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGING9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan.May 5 2020, 19:09

Revision Contents
Changeset List

PathSize
src/
rpc/
548 lines

Diff 19078

View Options

src/rpc/mining.cpp

Loading...