Page MenuHomePhabricator
Differential D5920

Pass rpc/misc RPC Results and Exmaples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 30 2020, 21:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan
rABC499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched misc.diff

Verify misc.diff doesn't exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-misc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10526
Build 18866: Default Diff Build & Tests
Build 18865: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 30 2020, 21:05
Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 21:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 21:05
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 21:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 30 2020, 21:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10526: Diff 19321.Apr 30 2020, 21:14
deadalnix accepted this revision.May 1 2020, 00:44
This revision is now accepted and ready to land.May 1 2020, 00:44
Closed by commit rABC499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan (authored by nakihito). · Explain WhyMay 1 2020, 01:02
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan.
nakihito added a commit: rSTAGING499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan.May 5 2020, 19:16
PiRK mentioned this in D10082: rpc: Limit echo to 10 args.Sep 9 2021, 12:03
PiRK mentioned this in rABC378a70f4ead6: rpc: Limit echo to 10 args.Sep 10 2021, 08:20

Revision Contents
Changeset List

PathSize
src/
rpc/
441 lines

Diff 19321

View Options

src/rpc/misc.cpp

Loading...