The user/pass is read from garg and stored into the config, to be fetched from there again by the exact same module. Even if we can move away from having so much global state, then a member variable for the http thing would make sense, not the config.
Details
Details
- Reviewers
jasonbcox majcosta - Group Reviewers
Restricted Project - Commits
- rSTAGING098078e485a0: Remove config managed RPC user/pass
rABC098078e485a0: Remove config managed RPC user/pass
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ConfigRPCUserAndPassword
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10531 Build 18875: Default Diff Build & Tests Build 18874: arc lint + arc unit