Page MenuHomePhabricator
Differential D5945

[rpc] mining: Omit uninitialized currentblockweight, currentblocktx
ClosedPublic
Actions

Authored by deadalnix on May 3 2020, 23:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe04b854d9b73: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx
rABCe04b854d9b73: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx
Summary

This is a backport of Core PR15383

Obviously currentblockweight => currentblocksize for us.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15383
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10571
Build 18953: Default Diff Build & Tests
Build 18952: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 3 2020, 23:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2020, 23:41
teamcity edited the summary of this revision. (Show Details)May 3 2020, 23:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 3 2020, 23:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 3 2020, 23:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10566: Diff 19391.May 3 2020, 23:51
deadalnix requested review of this revision.May 3 2020, 23:51
Fabien requested changes to this revision.May 4 2020, 07:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mining_basic.py
53 ↗(On Diff #19391)

This would cause the test without wallet to fail. Either use a generatetoaddress or the skip directive is there is no wallet.
It's weird that core still has this...

This revision now requires changes to proceed.May 4 2020, 07:02
deadalnix updated this revision to Diff 19398.May 4 2020, 13:33

Fix the test when runnign without wallet.

teamcity added a comment.May 4 2020, 13:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.May 4 2020, 13:47
This revision is now accepted and ready to land.May 4 2020, 13:47
This revision was landed with ongoing or failed builds.May 4 2020, 14:00
Closed by commit rABCe04b854d9b73: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe04b854d9b73: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx.
deadalnix added a commit: rSTAGINGe04b854d9b73: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
doc/
3 lines
src/
6 lines
17 lines
rpc/
17 lines
4 lines
test/
functional/
30 lines
test_framework/
6 lines

Diff 19398

View Options

doc/release-notes.md

Loading...
View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

test/functional/mining_basic.py

Loading...
View Options

test/functional/test_framework/blocktools.py

Loading...