Page MenuHomePhabricator
Differential D5977

Delete globals.h and globals.cpp
ClosedPublic
Actions

Authored by majcosta on May 6 2020, 10:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc4212b8948f8: Delete globals.h and globals.cpp
rABCc4212b8948f8: Delete globals.h and globals.cpp
Summary

They're unused and involved in circular dependencies

Test Plan
ninja check
./test/lint/lint-circular-dependencies.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_global
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10606
Build 19022: Default Diff Build & Tests
Build 19021: arc lint + arc unit

Event Timeline

majcosta created this revision.May 6 2020, 10:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 10:02
majcosta requested review of this revision.May 6 2020, 10:02
teamcity added a comment.May 6 2020, 10:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 6 2020, 10:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10606: Diff 19718.May 6 2020, 10:21
deadalnix requested changes to this revision.May 6 2020, 12:54
deadalnix added a subscriber: deadalnix.

autotool build.

This revision now requires changes to proceed.May 6 2020, 12:54
majcosta updated this revision to Diff 19724.May 6 2020, 13:20

removed references to globals.* in Makefile.am

teamcity added a comment.May 6 2020, 13:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.May 6 2020, 13:25
deadalnix retitled this revision from Delete globa.h and global.cpp to Delete globals.h and globals.cpp.
This revision is now accepted and ready to land.May 6 2020, 13:25
teamcity added a comment.May 6 2020, 13:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10609: Diff 19724.May 6 2020, 13:30
Closed by commit rABCc4212b8948f8: Delete globals.h and globals.cpp (authored by majcosta). · Explain WhyMay 6 2020, 13:31
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc4212b8948f8: Delete globals.h and globals.cpp.
majcosta added a commit: rSTAGINGc4212b8948f8: Delete globals.h and globals.cpp.May 6 2020, 14:35

Revision Contents
Changeset List

Diff 19718

View Options

src/CMakeLists.txt

Loading...
View Options

src/config.cpp

Loading...
View Options

src/globals.h

Loading...
View Options

src/globals.cpp

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...