Page MenuHomePhabricator

Delete globals.h and globals.cpp
ClosedPublic

Authored by majcosta on May 6 2020, 10:02.

Details

Summary

They're unused and involved in circular dependencies

Test Plan
ninja check
./test/lint/lint-circular-dependencies.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_global
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10609
Build 19028: Default Diff Build & Tests
Build 19027: arc lint + arc unit

Event Timeline

majcosta requested review of this revision.May 6 2020, 10:02
deadalnix requested changes to this revision.May 6 2020, 12:54
deadalnix added a subscriber: deadalnix.

autotool build.

This revision now requires changes to proceed.May 6 2020, 12:54

removed references to globals.* in Makefile.am

deadalnix retitled this revision from Delete globa.h and global.cpp to Delete globals.h and globals.cpp.
This revision is now accepted and ready to land.May 6 2020, 13:25
This revision was automatically updated to reflect the committed changes.