Page MenuHomePhabricator
Differential D5990

Add missing includes
ClosedPublic
Actions

Authored by Fabien on May 7 2020, 08:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8d33df907286: Add missing includes
rABC8d33df907286: Add missing includes
Summary

As per title, needed for coming changes.

They are fixed by core in commit
https://github.com/bitcoin/bitcoin/pull/17996/commits/c2bd5888607d283a229c9361747a93c83dfea0de
from the very unrelated PR17996, but since this PR has an infinite depth
of dependencies I just cherry pick this commit for now.

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
missing_headers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10630
Build 19067: Default Diff Build & Tests
Build 19066: arc lint + arc unit

Event Timeline

Fabien created this revision.May 7 2020, 08:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 08:05
Fabien requested review of this revision.May 7 2020, 08:05
teamcity edited the summary of this revision. (Show Details)May 7 2020, 08:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 7 2020, 08:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien updated this revision to Diff 19781.May 7 2020, 08:10

Fix author

teamcity added a comment.May 7 2020, 08:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 7 2020, 08:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10629: Diff 19780.May 7 2020, 08:19
teamcity added a comment.May 7 2020, 08:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10630: Diff 19781.May 7 2020, 08:23
deadalnix accepted this revision.May 7 2020, 14:26
This revision is now accepted and ready to land.May 7 2020, 14:26
Closed by commit rABC8d33df907286: Add missing includes (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyMay 7 2020, 14:45
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8d33df907286: Add missing includes.
Fabien added a commit: rSTAGING8d33df907286: Add missing includes.May 7 2020, 14:50

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines

Diff 19781

View Options

src/indirectmap.h

Loading...
View Options

src/memusage.h

Loading...