Page MenuHomePhabricator
Differential D5985

test: Bump MAX_NODES to 12
ClosedPublic
Actions

Authored by deadalnix on May 6 2020, 21:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe63d79923b67: test: Bump MAX_NODES to 12
rABCe63d79923b67: test: Bump MAX_NODES to 12
Summary

test: Speed up cache creation

This is a backport of Core PR16042

Depends on D5984

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16042
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10635
Build 19077: Default Diff Build & Tests
Build 19076: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 6 2020, 21:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 21:26
deadalnix requested review of this revision.May 6 2020, 21:26
teamcity edited the summary of this revision. (Show Details)May 6 2020, 21:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 6 2020, 21:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 6 2020, 21:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10622: Diff 19767.May 6 2020, 21:37
Fabien requested changes to this revision.May 7 2020, 07:18
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_framework.py
32 ↗(On Diff #19767)

It's removed in the PR. If it's needed then let it at the correct place

452 ↗(On Diff #19767)

Nit: move comment on it's own line

This revision now requires changes to proceed.May 7 2020, 07:18
deadalnix updated this revision to Diff 19788.May 7 2020, 14:22

Update as per comments

teamcity added a comment.May 7 2020, 14:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.May 7 2020, 14:27
This revision is now accepted and ready to land.May 7 2020, 14:27
teamcity added a comment.May 7 2020, 14:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10635: Diff 19788.May 7 2020, 14:35
Closed by commit rABCe63d79923b67: test: Bump MAX_NODES to 12 (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 7 2020, 14:58
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe63d79923b67: test: Bump MAX_NODES to 12.
deadalnix added a commit: rSTAGINGe63d79923b67: test: Bump MAX_NODES to 12.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
100 lines
69 lines
2 lines

Diff 19788

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...