Fix walletdb_tests on windows
ClosedPublic
Actions

Authored by deadalnix on Dec 11 2017, 19:12.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING00fd75952b27: Fix walletdb_tests on windows
rABC00fd75952b27: Fix walletdb_tests on windows

Summary

Windows is a bit more restrictive when it comes to files not properly closed and alike. This caused an error in the cleanup after running hte test (the DB files were kept open and couldn't be deleted).

This ensure that the DB is closed properly after use. The use of MockDB ensure that files shared accross DB instance such as db.log do get mamaged in memory instead of on disk.

Test Plan

Cross compile windows binaries, then

wine src/test/test_bitcoin.exe -t walletdb_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

walletdbdelete

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1331
Build 1331: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 11 2017, 19:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 19:12

Harbormaster completed remote builds in B1327: Diff 2046.Dec 11 2017, 19:12

schancel accepted this revision.Dec 11 2017, 19:42

schancel added inline comments.

src/wallet/test/walletdb_tests.cpp
12 ↗	(On Diff #2046)	Other tests are putting these kinds of things in the anonymous namespace. Should we do that here?
28 ↗	(On Diff #2046)	Nit: Missing space at end of string. Will produce `for testfdsfhads`