HomePhabricator

Fix walletdb_tests on windows
00fd75952b27Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix walletdb_tests on windows

Summary:
Windows is a bit more restrictive when it comes to files not properly closed and alike. This caused an error in the cleanup after running hte test (the DB files were kept open and couldn't be deleted).

This ensure that the DB is closed properly after use. The use of MockDB ensure that files shared accross DB instance such as db.log do get mamaged in memory instead of on disk.

Test Plan:
Cross compile windows binaries, then

wine src/test/test_bitcoin.exe -t walletdb_tests

Reviewers: schancel, #bitcoin_abc

Reviewed By: schancel, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D791

Details

Provenance
deadalnixAuthored on Dec 11 2017, 19:03
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D791: Fix walletdb_tests on windows
Parents
rSTAGING09dc40569ae3: Add pubkey prefix constants to include/secp256k1.h
Branches
Unknown
Tags
Unknown