Page MenuHomePhabricator

random: stop retrieving random bytes from OpenSSL
ClosedPublic

Authored by Fabien on May 25 2020, 07:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1092598e82c8: random: stop retrieving random bytes from OpenSSL
Summary
On the ::SLOW path we would use OpenSSL as an additional source of
random bytes. This commit removes that functionality. Note that this was
always only an additional source, and that we never checked the return
value

RAND_bytes():
https://www.openssl.org/docs/manmaster/man3/RAND_bytes.html

RAND_bytes() puts num cryptographically strong pseudo-random bytes into
buf.

Partial backport of core PR17265:
https://github.com/bitcoin/bitcoin/pull/17265/commits/4fcfcc294e7cb17956e283d09050cb997093a35d

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 25 2020, 07:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 25 2020, 13:17