Page MenuHomePhabricator
Differential D6275

Fix deprecated ByteSize() for protobuf >= 3.1
ClosedPublic
Actions

Authored by Fabien on May 28 2020, 10:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1
Summary

Based on the reverted D5386 but accounting on protobuf version to remain
compatible.
Note that autotools will still have the warning.

Test Plan

With protobuf >= 3.1:

ninja check

Make sure the warning is gone.

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2020, 10:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 10:04
Fabien requested review of this revision.May 28 2020, 10:04
teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) started.

teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) started.

teamcity added a comment.May 28 2020, 10:05

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) started.

teamcity added a comment.May 28 2020, 10:06

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 10:08

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 10:10

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) passed.

teamcity added a comment.May 28 2020, 10:13

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) passed.

teamcity added a comment.May 28 2020, 10:17

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11060: Diff 20659.May 28 2020, 10:18
teamcity added a comment.May 28 2020, 10:23

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) passed.

deadalnix added a subscriber: deadalnix.May 28 2020, 12:32
deadalnix added inline comments.
src/qt/CMakeLists.txt
257 ↗(On Diff #20659)

Can we simply require 3.1 and on? debian stable ship with 3.6 so that should be alright.

Fabien added inline comments.May 28 2020, 12:38
src/qt/CMakeLists.txt
257 ↗(On Diff #20659)

That would prevent from building on any Ubuntu LTS prior to the latest one which is only 1 month old.

deadalnix accepted this revision.May 28 2020, 14:30
This revision is now accepted and ready to land.May 28 2020, 14:30
Closed by commit rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1 (authored by Fabien). · Explain WhyMay 28 2020, 14:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1.

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines
11 lines

Diff 20671

View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/paymentserver.cpp

Loading...