Page MenuHomePhabricator
Differential D6301

Merge #15345: net: Correct comparison of addr count
ClosedPublic
Actions

Authored by jasonbcox on May 29 2020, 22:31.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC7df5863a2333: Merge #15345: net: Correct comparison of addr count
Summary

107623c26c2113428446effaa24edb986a3e780c net: Correct comparison of addr count (Carl Dong)

Pull request description:

`LOCAL_NONE` is supposed to be an enum indicating the `nScore` of a
`LocalServiceInfo` rather than the count of an addr in `mapLocalHost`.

Tree-SHA512: a47a0859dd11c991d75b54e96b08c502e3d235f7a6522a2355053f377d05e7853483996919292f458d917a561b23951e6945d6bf0ff5a2f29513c477c640bdd2

Backport of Core PR15345

Test Plan

ninja check for sanity

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 29 2020, 22:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 22:31
jasonbcox requested review of this revision.May 29 2020, 22:31
teamcity edited the summary of this revision. (Show Details)May 29 2020, 22:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 29 2020, 22:32

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 22:33

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 22:34

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 22:34

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 22:40

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 29 2020, 22:43

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11096: Diff 20722.May 29 2020, 22:43
deadalnix accepted this revision.May 29 2020, 22:51
This revision is now accepted and ready to land.May 29 2020, 22:51
Closed by commit rABC7df5863a2333: Merge #15345: net: Correct comparison of addr count (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 30 2020, 00:43
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC7df5863a2333: Merge #15345: net: Correct comparison of addr count.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 20729

View Options

src/net.cpp

Loading...