HomePhabricator

[wallet] abort when attempting to fund a transaction above maxtxfee

Description

[wallet] abort when attempting to fund a transaction above maxtxfee

Summary:
FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior.

This is a backport of Core PR16257

Depends on D6267

Test Plan:

ninja all check-all

Also run the test suite on the no wallet build

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D6268

Details

Provenance
Sjors Provoost <sjors@sprovoost.nl>Authored on Jun 29 2019, 02:44
deadalnixCommitted on May 29 2020, 22:17
deadalnixPushed on May 29 2020, 22:17
Reviewer
Restricted Project
Differential Revision
D6268: [wallet] abort when attempting to fund a transaction above maxtxfee
Parents
rABCe19a6b1c5386: Pass Consensus::Params to load block index family of functions
Branches
Unknown
Tags
Unknown