This option is confusing as it only turns a subset of warnings into
errors (some being only available on Clang), making it difficult to use.
It actually provides little to no benefit over the default ability to
add custom flags to the build, either with the environment CFLAGS and
CXXFLAGS or the cmake CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.
Further more, -Werror is now enabled on CI (D6315).
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC23072412ae7b: [CMAKE] Remove the ENABLE_WERROR option
cmake -GNinja .. -DENABLE_WERROR=ON
Check cmake warns about the unused variable.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_remove_werror
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 11141 Build 20824: Default Diff Build & Tests Build 20823: Build without Wallet Build 20822: Build with clang-10 Build 20821: arc lint + arc unit