HomePhabricator

[CI] Use proper argument handling in build_cmake.sh

Description

[CI] Use proper argument handling in build_cmake.sh

Summary:
D6315 was branching on $1 to check for an option but will fail due to
unbound variable (set -u) if no argument is set.
This diffs use proper handling to avoid the issue and make later
improvements easier.

Test Plan:
Run the build-clang-10 CI build, or any other using the --Werror
option.
Run the build-osx CI build, or any other not using the --Werror
option.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D6325

Details

Provenance
FabienAuthored on Jun 2 2020, 15:04
FabienPushed on Jun 2 2020, 15:55
Reviewer
Restricted Project
Differential Revision
D6325: [CI] Use proper argument handling in build_cmake.sh
Parents
rABCc88c96fd554a: [CI] Enable -Werror where possible
Branches
Unknown
Tags
Unknown