Page MenuHomePhabricator
Differential D6325

[CI] Use proper argument handling in build_cmake.sh
ClosedPublic
Actions

Authored by Fabien on Jun 2 2020, 15:12.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCaa44714884ae: [CI] Use proper argument handling in build_cmake.sh
Summary

D6315 was branching on $1 to check for an option but will fail due to
unbound variable (set -u) if no argument is set.
This diffs use proper handling to avoid the issue and make later
improvements easier.

Test Plan

Run the build-clang-10 CI build, or any other using the --Werror
option.
Run the build-osx CI build, or any other not using the --Werror
option.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 2 2020, 15:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 15:12
Fabien requested review of this revision.Jun 2 2020, 15:12
teamcity added a comment.Jun 2 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-clang-10) started.

teamcity added a comment.Jun 2 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Fabien planned changes to this revision.Jun 2 2020, 15:12
teamcity added a comment.Jun 2 2020, 15:13

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 2 2020, 15:14

Build Bitcoin ABC Diffs / Diff Testing (build-osx) started.

teamcity added a comment.Jun 2 2020, 15:24

Build Bitcoin ABC Diffs / Diff Testing (build-clang-10) passed.

teamcity added a comment.Jun 2 2020, 15:24

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 2 2020, 15:26

Build Bitcoin ABC Diffs / Diff Testing (build-osx) passed.

teamcity added a comment.Jun 2 2020, 15:28

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11138: Diff 20791.Jun 2 2020, 15:28
Fabien requested review of this revision.Jun 2 2020, 15:30
jasonbcox accepted this revision.Jun 2 2020, 15:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/devtools/build_cmake.sh
32 ↗(On Diff #20791)

nit: this doesn't need quotes

This revision is now accepted and ready to land.Jun 2 2020, 15:31
Fabien updated this revision to Diff 20794.Jun 2 2020, 15:33

Remove quotes

teamcity added a comment.Jun 2 2020, 15:34

Build Bitcoin ABC Diffs / Diff Testing (build-clang-10) started.

teamcity added a comment.Jun 2 2020, 15:34

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 2 2020, 15:34

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Harbormaster completed remote builds in B11140: Diff 20794.Jun 2 2020, 15:52
Closed by commit rABCaa44714884ae: [CI] Use proper argument handling in build_cmake.sh (authored by Fabien). · Explain WhyJun 2 2020, 15:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCaa44714884ae: [CI] Use proper argument handling in build_cmake.sh.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
27 lines

Diff 20796

View Options

contrib/devtools/build_cmake.sh

Loading...