Page MenuHomePhabricator

[CI] Use proper argument handling in build_cmake.sh
ClosedPublic

Authored by Fabien on Jun 2 2020, 15:12.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCaa44714884ae: [CI] Use proper argument handling in build_cmake.sh
Summary

D6315 was branching on $1 to check for an option but will fail due to
unbound variable (set -u) if no argument is set.
This diffs use proper handling to avoid the issue and make later
improvements easier.

Test Plan

Run the build-clang-10 CI build, or any other using the --Werror
option.
Run the build-osx CI build, or any other not using the --Werror
option.

Event Timeline

Fabien requested review of this revision.Jun 2 2020, 15:12
Fabien planned changes to this revision.Jun 2 2020, 15:12
Fabien requested review of this revision.Jun 2 2020, 15:30
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/devtools/build_cmake.sh
32 ↗(On Diff #20791)

nit: this doesn't need quotes

This revision is now accepted and ready to land.Jun 2 2020, 15:31