Differential D6365

[CMAKE] Prevent using jemalloc with the sanitizers
ClosedPublic
Actions

Authored by Fabien on Jun 4 2020, 12:43.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC62d103aa2e8f: [CMAKE] Prevent using jemalloc with the sanitizers

Summary

The sanitizers require instrumentation of the allocation functions and
are generally not compatible with jemalloc. In a worst case scenario
this could lead to false negative. This diffs disables jemalloc when a
sanitizer is enabled and prints a warning.

Test Plan

Should print a warning:

cmake -GNinja .. \
  -DENABLE_SANITIZERS=address \
  -DUSE_JEMALLOC_EXPERIMENTAL=ON

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_jemalloc_asan_tsan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11195
Build 21034: Default Diff Build & Tests
Build 21033: Build without Wallet
Build 21032: Build with clang-10
Build 21031: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 4 2020, 12:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 12:43

Fabien requested review of this revision.Jun 4 2020, 12:43

Fabien planned changes to this revision.Jun 4 2020, 12:47

Fabien retitled this revision from [CMAKE] Prevent using the sanitizers with jemalloc to [CMAKE] Prevent using jemalloc with the sanitizers .Jun 4 2020, 12:51

Fabien edited the summary of this revision. (Show Details)

Fabien edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B11194: Diff 20883.Jun 4 2020, 12:52