Page MenuHomePhabricator
Differential D6042

Use jemalloc as a default
ClosedPublic
Actions

Authored by Fabien on May 12 2020, 13:03.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0f1539259c1f: Use jemalloc as a default
Summary

Including the gitian builds. Minimum version is set to 3.6.0 which is
widely distributed (tested on Ubuntu 18.04).

Depends on D6365.

Test Plan

Read the docs.
Run the gitian build twice on different machines and check the build is
deterministic.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 12 2020, 13:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 13:03
Fabien requested review of this revision.May 12 2020, 13:03
teamcity added a comment.May 12 2020, 13:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 12 2020, 13:07

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.May 12 2020, 13:08

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.May 12 2020, 13:08

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.May 12 2020, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10713: Diff 19947.May 12 2020, 13:19
teamcity added a comment.May 12 2020, 13:20

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.May 12 2020, 13:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.May 12 2020, 13:49

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

deadalnix added a subscriber: deadalnix.May 12 2020, 14:36

It's always somewhat of a problem to use soething different in the dev environement and in prod. I would like to understand what is the plan to rollout jemalloc in prod before going forward and making it default in dev.

deadalnix accepted this revision.May 12 2020, 21:32
This revision is now accepted and ready to land.May 12 2020, 21:32
Fabien added a comment.May 12 2020, 21:33

jemalloc is part of the gitian build. It is only disabled when building the source archive, because we don't care about dependencies at this stage.

Fabien planned changes to this revision.May 14 2020, 12:32
Fabien updated this revision to Diff 20257.May 19 2020, 11:16

Rebase

This revision is now accepted and ready to land.May 19 2020, 11:16
Fabien planned changes to this revision.May 19 2020, 11:16
teamcity added a comment.May 19 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Fabien removed a parent revision: D6038: [DEPENDS] Add jemalloc to the depends.May 19 2020, 11:16
teamcity added a comment.May 19 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien edited the summary of this revision. (Show Details)May 19 2020, 11:16
teamcity added a comment.May 19 2020, 11:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 11:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B10848: Diff 20257.May 19 2020, 11:32
teamcity added a comment.May 19 2020, 11:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien updated this revision to Diff 20882.Jun 4 2020, 11:29

Rebase

This revision is now accepted and ready to land.Jun 4 2020, 11:29
Harbormaster completed remote builds in B11193: Diff 20882.Jun 4 2020, 11:54
Fabien edited the summary of this revision. (Show Details)Jun 4 2020, 12:57
Fabien added a parent revision: D6365: [CMAKE] Prevent using jemalloc with the sanitizers.
Fabien updated this revision to Diff 20885.Jun 4 2020, 12:58

Rebase on top of D6365.

Harbormaster completed remote builds in B11196: Diff 20885.Jun 4 2020, 13:15
Closed by commit rABC0f1539259c1f: Use jemalloc as a default (authored by Fabien). · Explain WhyJun 4 2020, 14:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0f1539259c1f: Use jemalloc as a default.

Revision Contents
Changeset List

PathSize
contrib/
debian/
1 line
gitian-descriptors/
3 lines
4 lines
3 lines
teamcity/
1 line
doc/
5 lines
2 lines
src/
7 lines

Diff 20894

View Options

contrib/debian/control

Loading...
View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-osx.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-win.yml

Loading...
View Options

contrib/teamcity/setup-debian-buster.sh

Loading...
View Options

doc/build-unix.md

Loading...
View Options

doc/dependencies.md

Loading...
View Options

src/CMakeLists.txt

Loading...