Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC0f1539259c1f: Use jemalloc as a default

Summary

Including the gitian builds. Minimum version is set to 3.6.0 which is
widely distributed (tested on Ubuntu 18.04).

Depends on D6365.

Test Plan

Read the docs.
Run the gitian build twice on different machines and check the build is
deterministic.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gitian_jemalloc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11193
Build 21026: Default Diff Build & Tests
Build 21025: Build without Wallet
Build 21024: Build with clang-10
Build 21023: arc lint + arc unit

Event Timeline

Fabien created this revision.May 12 2020, 13:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 13:03

Fabien requested review of this revision.May 12 2020, 13:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10713: Diff 19947.May 12 2020, 13:19

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

It's always somewhat of a problem to use soething different in the dev environement and in prod. I would like to understand what is the plan to rollout jemalloc in prod before going forward and making it default in dev.

deadalnix accepted this revision.May 12 2020, 21:32

This revision is now accepted and ready to land.May 12 2020, 21:32

jemalloc is part of the gitian build. It is only disabled when building the source archive, because we don't care about dependencies at this stage.

Fabien planned changes to this revision.May 14 2020, 12:32

Rebase

This revision is now accepted and ready to land.May 19 2020, 11:16

Fabien planned changes to this revision.May 19 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Fabien removed a parent revision: D6038: [DEPENDS] Add jemalloc to the depends.May 19 2020, 11:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien edited the summary of this revision. (Show Details)May 19 2020, 11:16