Differential D6420

[backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 22:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC5bdc385b0f6a: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay

Summary

Higher wallet-tx method combining RelayWalletTransactions and
AcceptToMemoryPool, using new Chain::broadcastTransaction

https://github.com/bitcoin/bitcoin/pull/15713/commits/611291c198eb2be9bf1aea1bf9b2187b18bdb3aa

Partial backport of Core PR15713

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11269
Build 21315: Default Diff Build & Tests
Build 21314: Build without Wallet
Build 21313: Build with clang-10
Build 21312: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 22:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 22:09

majcosta requested review of this revision.Jun 6 2020, 22:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11269: Diff 21006.Jun 6 2020, 22:19

majcosta added a child revision: D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.Jun 6 2020, 22:24

deadalnix accepted this revision.Jun 6 2020, 22:36

deadalnix edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jun 6 2020, 22:38

majcosta added a child revision: D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.Jun 6 2020, 22:56

Closed by commit rABC5bdc385b0f6a: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyJun 7 2020, 00:34

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC5bdc385b0f6a: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

13 lines

wallet.cpp

73 lines

Diff 21006

View Options

src/wallet/wallet.h