Differential D6552

[backport#16026] Ensure that uncompressed public keys in a multisig always returns a legacy address
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 16:17.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf14a55dc9e1b: [backport#16026] Ensure that uncompressed public keys in a multisig always…

Summary

a49503402b6bc21e3878e151c07529941d36aed0 Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow)

Pull request description:

`CreateMultisigRedeemscript()` is changed to `AddAndGetMultisigDestination()` so that the process of constructing the redeemScript and then getting the `CTxDestination` are done in the same function. This allows that function to see what the keys in the multisig are so that the correct address type is returned from `AddAndGetDestinationForScript()`.

This only effects the `createmultisig` and `addmultisigaddress` RPCs and does not change signing logic as #16022 does.

Alternative to #16022 and #16012

Fixes #16011

Backport of Core PR16026

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16026

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11447
Build 21939: Default Diff Build & Tests	Link to the build
Build 21938: Build without Wallet	Link to the build
Build 21937: Build with clang-10	Link to the build
Build 21936: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 12 2020, 16:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 16:17

majcosta requested review of this revision.Jun 12 2020, 16:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Jun 12 2020, 16:38

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/rpc/util.cpp
7	Let's include it in the .h and the .cpp for good measure XD
9	Maybe this guy needs to be first.
test/functional/rpc_createmultisig.py
81	Remove redundant tests.