Differential D6556

[backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProvider
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 19:03.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rABC19779479d79c: [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to…

Summary

-BEGIN VERIFY SCRIPT-
git grep -l "CBasicKeyStore" | xargs sed -i -e 's/CBasicKeyStore/FillableSigningProvider/g'
-END VERIFY SCRIPT-

https://github.com/bitcoin/bitcoin/pull/16227/commits/d9becff4e13da8e182631baa79b9794c03d44434

Depends on D6555

Partial backport of Core PR16227

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11453
Build 21963: Default Diff Build & Tests	Link to the build
Build 21962: Build without Wallet	Link to the build
Build 21961: Build with clang-10	Link to the build
Build 21960: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 12 2020, 19:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 19:03

majcosta requested review of this revision.Jun 12 2020, 19:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6557: [backport#16227 5/8] Move KeyOriginInfo to its own header file.Jun 12 2020, 19:05

Harbormaster completed remote builds in B11453: Diff 21336.Jun 12 2020, 19:25

nakihito accepted this revision.Jun 12 2020, 20:34

This revision is now accepted and ready to land.Jun 12 2020, 20:34

Closed by commit rABC19779479d79c: [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to… (authored by majcosta). · Explain WhyJun 13 2020, 20:14

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC19779479d79c: [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to….

Revision Contents
Changeset List

Path

Size

doc/

developer-notes.md

2 lines

src/

bench/

5 lines

4 lines

4 lines

44 lines

2 lines

2 lines

rpc/

misc.cpp

2 lines

rawtransaction.cpp

2 lines

rawtransaction_util.h

4 lines

rawtransaction_util.cpp

2 lines

util.h

6 lines

util.cpp

6 lines

test/

denialofservice_tests.cpp

2 lines

multisig_tests.cpp

2 lines

script_p2sh_tests.cpp

6 lines

script_tests.cpp

2 lines

transaction_tests.cpp

13 lines

txvalidationcache_tests.cpp

2 lines

wallet/

crypter.h

2 lines

crypter.cpp

12 lines

wallet.h

4 lines

Diff 21336

View Options

doc/developer-notes.md

View Options

src/bench/ccoins_caching.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/keystore.h

View Options

src/keystore.cpp

View Options

src/outputtype.h

View Options

src/outputtype.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.h

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/util.h

View Options

src/rpc/util.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/wallet/crypter.h

View Options

src/wallet/crypter.cpp

View Options

[backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProviderClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21336

doc/developer-notes.md

src/bench/ccoins_caching.cpp

src/bitcoin-tx.cpp

src/keystore.h

src/keystore.cpp

src/outputtype.h

src/outputtype.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.h

src/rpc/rawtransaction_util.cpp

src/rpc/util.h

src/rpc/util.cpp

src/test/denialofservice_tests.cpp

src/test/multisig_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/crypter.h

src/wallet/crypter.cpp

src/wallet/wallet.h

[backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProvider
ClosedPublic
Actions

Revision Contents
Changeset List