Page MenuHomePhabricator
Differential D6627

[CI] Add a build plan to run clang-tidy on the changed files
ClosedPublic
Actions

Authored by Fabien on Jun 17 2020, 19:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCfdaed1dcc29d: [CI] Add a build plan to run clang-tidy on the changed files
Summary

This is planned to run on each diff as is fast and will prevent from
missing brackets.

Test Plan

Run the build plan on CI.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 17 2020, 19:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 19:10
Fabien requested review of this revision.Jun 17 2020, 19:10
teamcity added a comment.Jun 17 2020, 19:15
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Jun 17 2020, 19:15
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Harbormaster completed remote builds in B11549: Diff 21502.Jun 17 2020, 19:15
teamcity added a comment.Jun 17 2020, 19:15
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Jun 17 2020, 19:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Jun 17 2020, 19:27
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Snippet of first build failure:

TeamCity server version is 2018.1.4 (build 58724), server timezone: UTC

[19:24:04]E: bt37 (3m:54s)
[19:24:04]i: TeamCity server version is 2018.1.4 (build 58724)
[19:24:04] : Compute revision for 'Bitcoin ABC Staging'
[19:24:04] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[19:24:04]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 24422
[19:24:04] :	 [Compute revision for 'Bitcoin ABC Staging'] Latest commit attached to build configuration: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[19:24:04] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[19:24:08] : The build is removed from the queue to be prepared for the start
[19:24:08] : Starting the build on the agent highperf7
[19:24:08]i: Agent time zone: Etc/UTC
[19:24:08]i: Agent is running under JRE: 1.8.0_252-b09
[19:24:08] : Clearing temporary directory: /home/teamcity/buildAgent/temp/buildTmp
[19:24:08] : Publishing internal artifacts (4s)
[19:24:12] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[19:24:12] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[19:24:08] : Clean build enabled: removing old files from /home/teamcity/buildAgent/work/jailed-build
[19:24:08] : Checkout directory: /home/teamcity/buildAgent/work/jailed-build
[19:24:08] : Updating sources: agent side checkout (2s)
[19:24:08] :	 [Updating sources] VCS Root: Bitcoin ABC Staging (2s)
[19:24:08] :		 [VCS Root: Bitcoin ABC Staging] checkout rules: =>bitcoin-abc; revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[19:24:08] :		 [VCS Root: Bitcoin ABC Staging] Git version: 2.20.1.0
[19:24:08] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (1s)
[19:24:08] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[19:24:08] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[19:24:08] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[19:24:10] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[19:24:10] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[19:24:10] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[19:24:10] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ea5a6d8b319c5c8426e261a5875491b2ec70e9fe --
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/21502
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[19:24:10] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[19:24:10] : Build preparation done
[19:24:10]E: Step 1/2: Command Line (3m:47s)
[19:24:10] :	 [Step 1/2] Ant JUnit report watcher
[19:24:10] :		 [Ant JUnit report watcher] Watching paths:
[19:24:10] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[19:24:10] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[19:24:10] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script5446115901694309050
[19:24:10] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[19:24:10] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:24:10] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:24:10] :	 [Step 1/2] Building base image for: ea5a6d8b3...
[19:24:10] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:24:13] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:24:13] :	 [Step 1/2] Tag name: abc-base-image-ea5a6d8b3
[19:27:57] :	 [Step 1/2] [Infrastructure Error] Failed to pull 'abc-base-image-ea5a6d8b3' from registry. See agent logs for details.
[19:27:57]W:	 [Step 1/2] Process exited with code 1
[19:27:57]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
deadalnix requested changes to this revision.Jun 17 2020, 22:14
deadalnix added a subscriber: deadalnix.

The error reported is completely unscrutable.

This revision now requires changes to proceed.Jun 17 2020, 22:14
Fabien requested review of this revision.EditedJun 18 2020, 07:00

The error is unrelated and caused by an infra failure.

In case of a missing brace the output looks like this:

clang-tidy found errors !
+ cat clang-tidy-warnings.txt
/home/fabien/bitcoin-abc/src/blockfilter.cpp:244:24: warning: statement should be inside braces [readability-braces-around-statements]
            if (!first) ret << ", ";
                       ^
                        {

+ exit 1
teamcity added a comment.Jun 18 2020, 07:06
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Snippet of first build failure:

TeamCity server version is 2018.1.4 (build 58724), server timezone: UTC

[07:03:20]E: bt37 (3m:27s)
[07:03:20]i: TeamCity server version is 2018.1.4 (build 58724)
[07:03:20] : Compute revision for 'Bitcoin ABC Staging'
[07:03:20] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[07:03:20]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 24422
[07:03:20] :	 [Compute revision for 'Bitcoin ABC Staging'] Latest commit attached to build configuration: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[07:03:20] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[07:03:24] : The build is removed from the queue to be prepared for the start
[07:03:24] : Starting the build on the agent highperf2
[07:03:25]i: Agent time zone: Etc/UTC
[07:03:25]i: Agent is running under JRE: 1.8.0_232-b09
[07:03:25] : Clearing temporary directory: /home/teamcity/buildAgent/temp/buildTmp
[07:03:25] : Publishing internal artifacts (4s)
[07:03:29] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[07:03:29] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[07:03:25] : Clean build enabled: removing old files from /home/teamcity/buildAgent/work/jailed-build
[07:03:25] : Checkout directory: /home/teamcity/buildAgent/work/jailed-build
[07:03:25] : Updating sources: agent side checkout (2s)
[07:03:25] :	 [Updating sources] VCS Root: Bitcoin ABC Staging (2s)
[07:03:25] :		 [VCS Root: Bitcoin ABC Staging] checkout rules: =>bitcoin-abc; revision: ea5a6d8b319c5c8426e261a5875491b2ec70e9fe
[07:03:25] :		 [VCS Root: Bitcoin ABC Staging] Git version: 2.20.1.0
[07:03:25] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (1s)
[07:03:25] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[07:03:25] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[07:03:25] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[07:03:26] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[07:03:27] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[07:03:27] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[07:03:27] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ea5a6d8b319c5c8426e261a5875491b2ec70e9fe --
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/21502
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/21502
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[07:03:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[07:03:27] : Build preparation done
[07:03:27]E: Step 1/2: Command Line (3m:19s)
[07:03:27] :	 [Step 1/2] Ant JUnit report watcher
[07:03:27] :		 [Ant JUnit report watcher] Watching paths:
[07:03:27] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[07:03:27] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[07:03:27] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script6813067254411535235
[07:03:27] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[07:03:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:03:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[07:03:27] :	 [Step 1/2] Building base image for: ea5a6d8b3...
[07:03:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:03:30] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[07:03:30] :	 [Step 1/2] Tag name: abc-base-image-ea5a6d8b3
[07:06:46] :	 [Step 1/2] [Infrastructure Error] Failed to pull 'abc-base-image-ea5a6d8b3' from registry. See agent logs for details.
[07:06:46]W:	 [Step 1/2] Process exited with code 1
[07:06:46]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Fabien updated this revision to Diff 21514.Jun 18 2020, 09:11

Rebase on top of D6635 to unbreak the CI

Harbormaster completed remote builds in B11559: Diff 21514.Jun 18 2020, 12:06
deadalnix added a comment.Jun 22 2020, 21:48

Can we see what CI reports?

Fabien updated this revision to Diff 21615.Jun 23 2020, 07:15

Rebase

Fabien updated this revision to Diff 21616.Jun 23 2020, 07:31

Change "errors" to "issues" in the message and move the file to the build dir.

Fabien added a child revision: D6675: Do not review.Jun 23 2020, 07:32
Harbormaster completed remote builds in B11620: Diff 21615.Jun 23 2020, 07:35
Harbormaster completed remote builds in B11621: Diff 21616.
teamcity added a comment.Jun 23 2020, 07:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien updated this revision to Diff 21619.Jun 23 2020, 08:52

Rebase on top of D6676

Harbormaster completed remote builds in B11624: Diff 21619.Jun 23 2020, 09:10
Fabien planned changes to this revision.Jun 23 2020, 09:10
Fabien updated this revision to Diff 21622.Jun 23 2020, 09:18

Pass the clang-tidy binary to the script

Fabien added a comment.Jun 23 2020, 09:34

@deadalnix Here is an example of the output in case of missing braces

Harbormaster completed remote builds in B11626: Diff 21622.Jun 23 2020, 09:36
deadalnix accepted this revision.Jun 23 2020, 11:45

There is some trash in the log.

This revision is now accepted and ready to land.Jun 23 2020, 11:45
Fabien added a comment.Jun 23 2020, 11:49

I'm working on cleaning the whole thing

Closed by commit rABCfdaed1dcc29d: [CI] Add a build plan to run clang-tidy on the changed files (authored by Fabien). · Explain WhyJun 23 2020, 14:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfdaed1dcc29d: [CI] Add a build plan to run clang-tidy on the changed files.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
26 lines

Diff 21633

View Options

contrib/teamcity/build-configurations.sh

Loading...