Differential D6683

[refactor] Refactor misbehavior ban decisions to MaybePunishNode()
ClosedPublic
Actions

Authored by deadalnix on Jun 23 2020, 15:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc02c6c9966ce: [refactor] Refactor misbehavior ban decisions to MaybePunishNode()

Summary

Isolate the decision of whether to ban a peer to one place in the
code, rather than having it sprinkled throughout net_processing.

Co-authored-by: Anthony Towns <aj@erisian.com.au>

Suhas Daftuar <sdaftuar@gmail.com>
John Newbery <john@johnnewbery.com>

This is a partial backport of Core PR15141 : https://github.com/bitcoin/bitcoin/pull/15141/commits/8818729013e17c650a25f030b2b80e0997389155

Slightly modified because the original screws with locks and only fixes it toward the end.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15141-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11641
Build 22655: Default Diff Build & Tests	Link to the build
Build 22654: Build without Wallet	Link to the build
Build 22653: Build with clang-10	Link to the build
Build 22652: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 23 2020, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2020, 15:16

deadalnix requested review of this revision.Jun 23 2020, 15:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6684: [refactor] drop IsInvalid(nDoSOut).Jun 23 2020, 15:28

Harbormaster completed remote builds in B11636: Diff 21641.Jun 23 2020, 15:42

Fabien accepted this revision.Jun 23 2020, 15:47

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
3081 ↗	(On Diff #21641)	Undo
3084 ↗	(On Diff #21641)	Dito

This revision is now accepted and ready to land.Jun 23 2020, 15:47

nits

This revision was landed with ongoing or failed builds.Jun 23 2020, 16:42

Closed by commit rABCc02c6c9966ce: [refactor] Refactor misbehavior ban decisions to MaybePunishNode() (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc02c6c9966ce: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().

Harbormaster completed remote builds in B11641: Diff 21648.Jun 23 2020, 16:58

PiRK mentioned this in D10414: ProcessOrphanTx: remove useless setMisbehaving set.Nov 2 2021, 10:40

PiRK mentioned this in rABCe2e197f5eff7: ProcessOrphanTx: remove useless setMisbehaving set.Nov 3 2021, 07:07

Revision Contents
Changeset List

Path

Size

src/

consensus/

validation.h

1 line

net_processing.cpp

114 lines

Diff 21648

View Options

src/consensus/validation.h