Differential D6698

[refactor] Add useful-for-dos "reason" field to CValidationState
ClosedPublic
Actions

Authored by deadalnix on Jun 24 2020, 01:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4ee2470e29ce: [refactor] Add useful-for-dos "reason" field to CValidationState

Summary

This is a first step towards cleaning up our DoS interface - make
validation return *why* something is invalid, and let net_processing
figure out what that implies in terms of banning/disconnection/etc.

Behavior change: peers will now be banned for providing blocks
with premature coinbase spends.

Co-authored-by: Anthony Towns <aj@erisian.com.au>

Suhas Daftuar <sdaftuar@gmail.com>

This is a partial backport of Core PR15141 : https://github.com/bitcoin/bitcoin/pull/15141/commits/34477ccd39a8d4bfa8ad612f22d5a46291922185

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15141-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11659
Build 22724: Default Diff Build & Tests	Link to the build
Build 22723: Build without Wallet	Link to the build
Build 22722: Build with clang-10	Link to the build
Build 22721: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 24 2020, 01:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 01:00

deadalnix requested review of this revision.Jun 24 2020, 01:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11653: Diff 21675.Jun 24 2020, 01:18

deadalnix added a child revision: D6699: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible.Jun 24 2020, 01:38

deadalnix added a child revision: D6700: LookupBlockIndex -> CACHED_INVALID.

Fabien requested changes to this revision.Jun 24 2020, 08:25

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/consensus/validation.h
39 ↗	(On Diff #21675)	That comment needs some segwit clearance. Not sure the enum makes much sense for us at all.
src/validation.cpp
1740 ↗	(On Diff #21675)	Note to reviewers: the behavior changed in D6693, now the ban happen in CheckInputs.