Page MenuHomePhabricator
Differential D6720

[LINTER] Enforce shellcheck >= 0.7.0
ClosedPublic
Actions

Authored by Fabien on Jun 24 2020, 20:13.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC606195478576: [LINTER] Enforce shellcheck >= 0.7.0
Summary

The recent changes from D6701 require the --source-path option which
is only available from 0.7.0. Since shellcheck can be download as a
standalone binary this is still easy to install.

Test Plan
arc lint --everything

Diff Detail

Event Timeline

Fabien created this revision.Jun 24 2020, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 20:13
Fabien requested review of this revision.Jun 24 2020, 20:13
jasonbcox accepted this revision.Jun 24 2020, 20:16
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/setup-debian-buster.sh
86

Macro likestamp:

This revision is now accepted and ready to land.Jun 24 2020, 20:16
Harbormaster completed remote builds in B11681: Diff 21718.Jun 24 2020, 20:36
Closed by commit rABC606195478576: [LINTER] Enforce shellcheck >= 0.7.0 (authored by Fabien). · Explain WhyJun 24 2020, 20:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC606195478576: [LINTER] Enforce shellcheck >= 0.7.0.

Revision Contents
Changeset List

PathSize
1 line
15 lines
arcanist/
linter/
11 lines
contrib/
teamcity/
9 lines

Diff 21718

View Options

.arclint

Loading...
View Options

CONTRIBUTING.md

Loading...
View Options

arcanist/linter/ShellCheckLinter.php

Loading...
View Options

contrib/teamcity/setup-debian-buster.sh

Loading...