Differential D6776

[avalanche] Use utility method to find slots
ClosedPublic
Actions

Authored by deadalnix on Jun 29 2020, 21:24.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC193c2f510578: [avalanche] Use utility method to find slots

Summary

It makes the code clearer.

Depends on D6773

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

slotcmp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11778
Build 23155: Default Diff Build & Tests	Link to the build
Build 23154: Build without Wallet	Link to the build
Build 23153: Build with clang-10	Link to the build
Build 23152: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 29 2020, 21:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 21:24

deadalnix requested review of this revision.Jun 29 2020, 21:24

deadalnix added a child revision: D6777: [avalanche] Abstract the Slot infos so that layout can be changed easily.Jun 29 2020, 21:29

Harbormaster completed remote builds in B11778: Diff 21869.Jun 29 2020, 21:39

jasonbcox accepted this revision.Jun 29 2020, 21:43

This revision is now accepted and ready to land.Jun 29 2020, 21:43

Closed by commit rABC193c2f510578: [avalanche] Use utility method to find slots (authored by deadalnix). · Explain WhyJun 30 2020, 01:37

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC193c2f510578: [avalanche] Use utility method to find slots.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

4 lines

peermanager.cpp

8 lines

test/

peermanager_tests.cpp

3 lines

Diff 21869

View Options

src/avalanche/peermanager.h

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

[avalanche] Use utility method to find slotsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21869

src/avalanche/peermanager.h

src/avalanche/peermanager.cpp

src/avalanche/test/peermanager_tests.cpp

[avalanche] Use utility method to find slots
ClosedPublic
Actions

Revision Contents
Changeset List