Page MenuHomePhabricator
Differential D6717

[backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin
ClosedPublic
Actions

Authored by majcosta on Jun 24 2020, 19:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCbf733950e6f5: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin
Summary

Instead of reserving keys, reserve destinations which are backed by keys

https://github.com/bitcoin/bitcoin/pull/16237/commits/33d13edd2bda0af90660e275ea4fa96ca9896f2a

Depends on D6716

Partial backport of Core PR16237

Test Plan
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.Jun 24 2020, 19:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 19:53
majcosta requested review of this revision.Jun 24 2020, 19:53
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 19:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11678: Diff 21715.Jun 24 2020, 20:05
majcosta added a child revision: D6721: [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations.Jun 24 2020, 20:17
majcosta updated this revision to Diff 21875.Jun 29 2020, 22:49

rebase

Harbormaster completed remote builds in B11783: Diff 21875.Jun 29 2020, 23:04
deadalnix accepted this revision.Jun 30 2020, 23:31
This revision is now accepted and ready to land.Jun 30 2020, 23:31
Closed by commit rABCbf733950e6f5: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 1 2020, 16:17
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCbf733950e6f5: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin.

Revision Contents
Changeset List

PathSize
src/
interfaces/
8 lines
wallet/
24 lines
test/
6 lines
65 lines
52 lines

Diff 21875

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...