Page MenuHomePhabricator

[backport#15492] [rpc] remove deprecated generate method
ClosedPublic

Authored by majcosta on Jun 24 2020, 18:12.

Details

Summary

[rpc] remove deprecated generate method
https://github.com/bitcoin/bitcoin/pull/15492/commits/8bb3e4c487500a580e3e18791b1f4e7dcdd35442

[wallet] remove unused GetScriptForMining
https://github.com/bitcoin/bitcoin/pull/15492/commits/07cae5287c4409e9e597b891899403220905881d


Update: considering this is a testing only RPC and it is blocking a bunch of current stuff (and part of a PR going back to D6269), discussion has been mostly in favor of shipping this a bit over a month ahead of the normal deprecation schedule.

Backport of Core PR15492

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested review of this revision.Jun 24 2020, 18:12
majcosta created this revision.
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 18:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Jun 25 2020, 06:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/CMakeLists.txt
450 ↗(On Diff #21706)

How come that removing stuff leads to added dependency ?

src/wallet/rpcwallet.cpp
3885 ↗(On Diff #21706)

AFAIK the next release is 0.21.10 :)

This revision now requires changes to proceed.Jun 25 2020, 06:44
Fabien added inline comments.Jun 25 2020, 06:45
src/wallet/rpcwallet.cpp
3885 ↗(On Diff #21706)

I just notice the [v0.22 ONLY] tag... I think you are trapping yourself into a rebase hell here.

majcosta retitled this revision from [backport#15492] [rpc] remove deprecated generate method [v0.22 ONLY] to [backport#15492] [rpc] remove deprecated generate method.Jun 28 2020, 21:47
majcosta edited the summary of this revision. (Show Details)
majcosta requested review of this revision.Jun 28 2020, 21:50
majcosta marked an inline comment as done.
majcosta added inline comments.
src/CMakeLists.txt
450 ↗(On Diff #21706)

ScriptErrorString(ScriptError) is defined in the script library and is called by rpc/rawtransaction_util.cpp

deadalnix requested changes to this revision.Jun 29 2020, 00:27
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
doc/release-notes.md
28 ↗(On Diff #21706)

Rebase

src/CMakeLists.txt
450 ↗(On Diff #21706)

It is not completely absurd for common to depend on script. The question is, does script depends on common? If so, we might have a problem.

This revision now requires changes to proceed.Jun 29 2020, 00:27
majcosta updated this revision to Diff 21862.Jun 29 2020, 19:34
majcosta marked an inline comment as done.

rebased

deadalnix requested changes to this revision.Jun 29 2020, 19:50
deadalnix added inline comments.
src/CMakeLists.txt
450 ↗(On Diff #21862)

Put script before util and secp256k1 .

This revision now requires changes to proceed.Jun 29 2020, 19:50
majcosta updated this revision to Diff 21863.Jun 29 2020, 20:03

changed library order in CMakeLists.tx

deadalnix accepted this revision.Jun 29 2020, 20:50
Fabien accepted this revision.Jun 30 2020, 19:51
This revision is now accepted and ready to land.Jun 30 2020, 19:51