Differential D6800

[backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success
ClosedPublic
Actions

Authored by majcosta on Jul 1 2020, 20:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc5263dffd160: [backport#16208 1/2] CreateTransaction calls KeepDestination on…

Summary

https://github.com/bitcoin/bitcoin/pull/16208/commits/d9ff862f2d24784ee081a8f62a76ffdfe409c10a

Partial backport of Core PR16208

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11812
Build 23276: Default Diff Build & Tests	Link to the build
Build 23275: Build without Wallet	Link to the build
Build 23274: Build with clang-10	Link to the build
Build 23273: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 1 2020, 20:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2020, 20:38

majcosta requested review of this revision.Jul 1 2020, 20:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.Jul 1 2020, 20:47

Harbormaster completed remote builds in B11812: Diff 21944.Jul 1 2020, 20:53

Fabien accepted this revision.Jul 2 2020, 08:42

This revision is now accepted and ready to land.Jul 2 2020, 08:42

Closed by commit rABCc5263dffd160: [backport#16208 1/2] CreateTransaction calls KeepDestination on… (authored by Gregory Sanders <gsanders87@gmail.com>, committed by majcosta). · Explain WhyJul 2 2020, 14:21

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCc5263dffd160: [backport#16208 1/2] CreateTransaction calls KeepDestination on….

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

13 lines

Diff 21944

View Options

[backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before successClosedPublicActions