[avalanche] Add a facility to update node's timeout
ClosedPublic
Actions

Authored by deadalnix on Jul 5 2020, 21:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

This feature is required as any reply from the node comes with a cooldown time.

Depends on D6824

Test Plan

ninja all check-avalanche

Repository

rABC Bitcoin ABC

Branch

avaupdaterequesttime

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11860
Build 23426: Default Diff Build & Tests	Link to the build
Build 23425: Build without Wallet	Link to the build
Build 23424: Build with clang-10	Link to the build
Build 23423: arc lint + arc unit

deadalnix requested review of this revision.Jul 5 2020, 21:59

Fabien accepted this revision.Jul 6 2020, 06:32

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/peermanager.cpp
121	What about making the timeout monotonic ? I don't think there is a valid scenario where it's value should be lowered (or set < now). It's maybe better suited to the callsite though, where the logic resides.