Page MenuHomePhabricator
Differential D838

Simplify input field validation for addresses
ClosedPublic
Actions

Authored by deadalnix on Dec 22 2017, 00:44.

Details

Reviewers
schancel
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGINGab79db66fc16: Simplify input field validation for addresses
rABCab79db66fc16: Simplify input field validation for addresses
Summary

This logic is less restrictive and allow to input cashaddr without prefix.

Test Plan

Compile bitcoin-qt and input a cashaddr without prefix in the amount field when sending coins.
Added unittests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendvalid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1433
Build 1433: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 22 2017, 00:44
Harbormaster completed remote builds in B1433: Diff 2219.Dec 22 2017, 00:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2017, 00:44
Herald added a reviewer: Restricted Project. · View Herald Transcript
schancel accepted this revision.Dec 22 2017, 00:51
This revision is now accepted and ready to land.Dec 22 2017, 00:51
Closed by commit rABCab79db66fc16: Simplify input field validation for addresses (authored by deadalnix). · Explain WhyDec 22 2017, 00:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2219

View Options

src/cashaddr.h

Loading...
View Options

src/cashaddr.cpp

Loading...
View Options

src/qt/bitcoinaddressvalidator.cpp

Loading...
View Options

src/qt/test/bitcoinaddressvalidatortests.cpp

Loading...