Refactor FormatStateMessage() to better match Core
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 00:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc3bbc613c4b6: Refactor FormatStateMessage() to better match Core

Summary

This completes the backport of Core PR16688 (see my note in the summary of D6652).
We diverge slightly due to a not-yet-backported change that will remove the RejectCode.

Depends on D6860

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 9 2020, 00:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 00:32

jasonbcox requested review of this revision.Jul 9 2020, 00:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11913: Diff 22097.Jul 9 2020, 00:45

Fabien accepted this revision.Jul 9 2020, 06:10

This revision is now accepted and ready to land.Jul 9 2020, 06:10

Closed by commit rABCc3bbc613c4b6: Refactor FormatStateMessage() to better match Core (authored by jasonbcox). · Explain WhyJul 14 2020, 21:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCc3bbc613c4b6: Refactor FormatStateMessage() to better match Core.

Revision Contents
Changeset List

Path

Size

src/

util/

validation.cpp

17 lines

Diff 22265

View Options

Refactor FormatStateMessage() to better match CoreClosedPublicActions