Page MenuHomePhabricator
Differential D6959

[backport#16194] refactoring: move block metadata structures into BlockManager
ClosedPublic
Actions

Authored by majcosta on Jul 17 2020, 02:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC06bba9f0e845: [backport#16194] refactoring: move block metadata structures into BlockManager
Summary

Separate out the management of chain-agnostic block metadata from any given
CChainState instance. This allows us to avoid duplicating data like
mapBlockIndex unnecessarily for multiple chainstates.

This also adds a CChainState constructor that accepts and sets m_blockman.
Ultimately this reference will point to a BlockMan instance that
is shared across CChainStates.

This commit can be decomposed into smaller commits if necessary.

Partial backport of Core PR16194

Test Plan
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.Jul 17 2020, 02:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2020, 02:40
majcosta requested review of this revision.Jul 17 2020, 02:40
teamcity edited the summary of this revision. (Show Details)Jul 17 2020, 02:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12038: Diff 22326.Jul 17 2020, 02:52
Fabien accepted this revision.Jul 17 2020, 06:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.h
705

Nit:

/**
 * lorem ipsum
 */
803

explicit

This revision is now accepted and ready to land.Jul 17 2020, 06:59
majcosta updated this revision to Diff 22344.Jul 17 2020, 20:05

fix nits and rebase

Harbormaster completed remote builds in B12051: Diff 22344.Jul 17 2020, 20:18
majcosta added a child revision: D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.Jul 17 2020, 20:19
majcosta updated this revision to Diff 23700.Sep 22 2020, 22:57

rebase after D7204

Harbormaster completed remote builds in B12870: Diff 23700.Sep 22 2020, 23:08
Closed by commit rABC06bba9f0e845: [backport#16194] refactoring: move block metadata structures into BlockManager (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhySep 22 2020, 23:47
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC06bba9f0e845: [backport#16194] refactoring: move block metadata structures into BlockManager.

Revision Contents
Changeset List

PathSize
src/
159 lines
157 lines

Diff 22326

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...