Differential D6984

[refactor] remove global mapBlockIndex access from parkblock RPC
ClosedPublic
Actions

Authored by majcosta on Jul 20 2020, 21:39.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC8a10f28311f0: [refactor] remove global mapBlockIndex access from parkblock RPC

Summary

this also makes parkblock's code more consistent with the pattern present
in the invalidateblock RPC

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

make_park_invalidate_uniform

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12074
Build 24087: Default Diff Build & Tests	build-diff
Build 24086: Build without Wallet	build-without-wallet
Build 24085: Build with clang-10	build-clang-10
Build 24084: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 20 2020, 21:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2020, 21:39

majcosta requested review of this revision.Jul 20 2020, 21:39

Harbormaster completed remote builds in B12074: Diff 22379.Jul 20 2020, 22:10

deadalnix accepted this revision.Jul 20 2020, 22:54

This revision is now accepted and ready to land.Jul 20 2020, 22:54

Closed by commit rABC8a10f28311f0: [refactor] remove global mapBlockIndex access from parkblock RPC (authored by majcosta). · Explain WhyJul 20 2020, 23:37

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC8a10f28311f0: [refactor] remove global mapBlockIndex access from parkblock RPC.

majcosta mentioned this in D6970: [backport#16194] refactoring: remove mapBlockIndex global.Jul 21 2020, 01:07

majcosta mentioned this in D6986: [refactor] remove global mapBlockIndex access from unparkblock RPC.Jul 21 2020, 01:59

majcosta mentioned this in rABCec474f67b2bd: [refactor] remove global mapBlockIndex access from unparkblock RPC.Jul 21 2020, 15:37

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

9 lines

Diff 22379

View Options

[refactor] remove global mapBlockIndex access from parkblock RPCClosedPublicActions