Page MenuHomePhabricator
Differential D7234

Add test coverage for getblocktemplate's sigoplimit
ClosedPublic
Actions

Authored by jasonbcox on Aug 20 2020, 22:39.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3d12fe01ab32: Add test coverage for getblocktemplate's sigoplimit
Summary

This value isn't expected to change for a while, but we should
test it anyway for sanity since we've already applied patches that
change its behavior in the past.

Part of T1014

Depends on D7233

Test Plan

test_runner.py abc_mining_basic

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gbt-sigoplimit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12444
Build 25049: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25048: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 20 2020, 22:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2020, 22:39
jasonbcox requested review of this revision.Aug 20 2020, 22:39
jasonbcox edited the summary of this revision. (Show Details)Aug 20 2020, 22:39
jasonbcox edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B12444: Diff 22997.Aug 20 2020, 23:14
Fabien requested changes to this revision.Aug 21 2020, 06:36
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_mining_basic.py
46

Use constants from cdefs

This revision now requires changes to proceed.Aug 21 2020, 06:36
jasonbcox updated this revision to Diff 23006.Aug 22 2020, 04:38

Use available constants

Harbormaster completed remote builds in B12451: Diff 23006.Aug 22 2020, 05:07
deadalnix accepted this revision.Aug 22 2020, 12:24
Fabien accepted this revision.Aug 24 2020, 06:38
This revision is now accepted and ready to land.Aug 24 2020, 06:38
Closed by commit rABC3d12fe01ab32: Add test coverage for getblocktemplate's sigoplimit (authored by jasonbcox). · Explain WhyAug 24 2020, 16:11
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC3d12fe01ab32: Add test coverage for getblocktemplate's sigoplimit.

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines

Diff 22997

View Options

test/functional/abc_mining_basic.py

Loading...