The LC_ALL=C.UTF-8 requirement is enforced to avoid locale causing
variance in shell scripts. But this setting is invalid on some linux
variants as it is not standard, and is causing more trouble than it is
useful.
Since the cmake util test_wrapper.sh is just a wrapper for a test
binary call which itself resets the locale, it can be simply discarded.
This will suppress a ton of warnings when running make check on
systems that don't support the C.UTF-8 locale (e.g. Archlinux).
Furthermore it will make the result consistent with a direct call to
test_bitcoin for example.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABCc153f8700314: [CMAKE] Don't enforce LC_ALL=C.UTF-8 for the cmake test wrapper script
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_test_utf8
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12471 Build 25095: Build Diff build-diff · build-clang-10 · build-clang-tidy · build-without-wallet Build 25094: arc lint + arc unit