Page MenuHomePhabricator
Differential D7258

Fixup build tagging
ClosedPublic
Actions

Authored by jasonbcox on Aug 26 2020, 23:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCWEB4cb3174a8b19: Fixup build tagging
Summary

PROJECT is not used and allowing to specify the entire tag
allows the CI to be more flexible.

Test Plan

make run

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
fixup-make-tag
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12481
Build 25108: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 26 2020, 23:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2020, 23:56
Harbormaster completed remote builds in B12478: Diff 23055.Aug 26 2020, 23:56
jasonbcox requested review of this revision.Aug 26 2020, 23:56
Fabien requested changes to this revision.Aug 27 2020, 06:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
Makefile
7 ↗(On Diff #23055)

Should be bitcoinabcorg, no ?

This revision now requires changes to proceed.Aug 27 2020, 06:22
jasonbcox updated this revision to Diff 23059.Aug 27 2020, 15:30

fix typo

Harbormaster completed remote builds in B12481: Diff 23059.Aug 27 2020, 15:30
jasonbcox added inline comments.Aug 27 2020, 15:31
Makefile
7 ↗(On Diff #23055)

woops. working on the bitcoincash.org website for too long. lol

Fabien accepted this revision.Aug 27 2020, 15:44
This revision is now accepted and ready to land.Aug 27 2020, 15:44
Closed by commit rABCWEB4cb3174a8b19: Fixup build tagging (authored by jasonbcox). · Explain WhyAug 27 2020, 21:30
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCWEB4cb3174a8b19: Fixup build tagging.

Revision Contents
Changeset List

PathSize
6 lines

Diff 23059

View Options

Makefile

Loading...