Page MenuHomePhabricator
Differential D7300

[backport#13966] Hide spendable label if private key is disabled
ClosedPublic
Actions

Authored by majcosta on Sep 1 2020, 19:59.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rABCb69646f0899a: [backport#13966] Hide spendable label if private key is disabled
Summary

https://github.com/bitcoin/bitcoin/pull/13966/commits/fe1ff5026bace9b43ac01c14a26ed0dd75ccc6f7

Partial backport of Core PR13966

Test Plan
ninja check
./src/qt/bitcoind -testnet

create a watch-only wallet, import some random address, see that there is no spendable label

Diff Detail

Event Timeline

majcosta created this revision.Sep 1 2020, 19:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2020, 19:59
majcosta requested review of this revision.Sep 1 2020, 19:59
teamcity edited the summary of this revision. (Show Details)Sep 1 2020, 19:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7301: [backport#13966] gui: Show watch-only eye instead of HD disabled.Sep 1 2020, 20:01
Harbormaster completed remote builds in B12539: Diff 23153.Sep 1 2020, 20:14
jasonbcox requested changes to this revision.Sep 1 2020, 20:30
jasonbcox added a subscriber: jasonbcox.

Summary points to wrong commit

This revision now requires changes to proceed.Sep 1 2020, 20:30
majcosta requested review of this revision.Sep 1 2020, 20:42
majcosta edited the summary of this revision. (Show Details)

fixed

deadalnix accepted this revision.Sep 1 2020, 22:20
jasonbcox accepted this revision.Sep 2 2020, 16:09
This revision is now accepted and ready to land.Sep 2 2020, 16:09
Closed by commit rABCb69646f0899a: [backport#13966] Hide spendable label if private key is disabled (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by majcosta). · Explain WhySep 2 2020, 16:11
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb69646f0899a: [backport#13966] Hide spendable label if private key is disabled.

Revision Contents
Changeset List

PathSize
src/
qt/
87 lines

Diff 23153

View Options

src/qt/overviewpage.cpp

Loading...