Page MenuHomePhabricator
Differential D7323

[backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization
ClosedPublic
Actions

Authored by majcosta on Sep 2 2020, 19:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfe89cb23e247: [backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization
Summary

If we're constructing the SafeDbt without provided data, it is always malloced,
so that is the case we expose.

Also run clang-format.

https://github.com/bitcoin/bitcoin/pull/14268/commits/4a86a0acd9ac3ca392f0584a5fd079a856e5e4ba#

Depends on D7322

Concludes backport of Core PR14268

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 2 2020, 19:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 19:38
majcosta requested review of this revision.Sep 2 2020, 19:38
teamcity edited the summary of this revision. (Show Details)Sep 2 2020, 19:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Sep 2 2020, 19:55
This revision is now accepted and ready to land.Sep 2 2020, 19:55
Harbormaster completed remote builds in B12565: Diff 23195.Sep 2 2020, 20:03
Closed by commit rABCfe89cb23e247: [backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization (authored by Ben Woosley <ben.woosley@gmail.com>, committed by majcosta). · Explain WhySep 2 2020, 20:31
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCfe89cb23e247: [backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization.

Revision Contents
Changeset List

PathSize
src/
wallet/
11 lines
4 lines

Diff 23195

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...