Page MenuHomePhabricator
Differential D7433

Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection
ClosedPublic
Actions

Authored by jasonbcox on Sep 11 2020, 21:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf78a9d2493ea: Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection
Summary

4670006762ffce654bb12edb5a7e64ad004122a7 test: remove redundant sync_with_ping after add_p2p_connection (Jon Atack)

Pull request description:

Now that #18247 is merged, these calls are redundant.

ACKs for top commit:

vasild:
  utACK 4670006

Tree-SHA512: bdbfe8bcf9dbdde0a8115e3a62bfe359910798d7a3010d920ffca07049cb5f97bf8fb9b6f70079b0607105192b61a6d665774e59a2b678597b47ad6237595ad5

Backport of Core PR18496

Test Plan

Run p2p_sendheaders a few times to make sure it's not flaky:

for X in {1..10}; do ./test/functional/test_runner.py p2p_sendheaders ; done

Diff Detail

Event Timeline

jasonbcox created this revision.Sep 11 2020, 21:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2020, 21:52
jasonbcox requested review of this revision.Sep 11 2020, 21:52
teamcity edited the summary of this revision. (Show Details)Sep 11 2020, 21:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Sep 11 2020, 21:54
This revision is now accepted and ready to land.Sep 11 2020, 21:54
Harbormaster completed remote builds in B12718: Diff 23466.Sep 11 2020, 22:04
Closed by commit rABCf78a9d2493ea: Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhySep 11 2020, 22:37
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCf78a9d2493ea: Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection.

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 23466

View Options

test/functional/p2p_sendheaders.py

Loading...