Page MenuHomePhabricator
Differential D7470

[CMAKE] Silent the man pages generation
ClosedPublic
Actions

Authored by Fabien on Sep 17 2020, 07:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf571f9774071: [CMAKE] Silent the man pages generation
Summary

This diff makes the man pages generation silent, unless there is a
failure.

Depends on D7473.

Test Plan
ninja install-manpages

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_silent_manpages_generation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12766
Build 25605: Build Diffbuild-without-wallet · build-clang-10 · build-clang-tidy · build-diff
Build 25604: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 17 2020, 07:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2020, 07:02
Fabien requested review of this revision.Sep 17 2020, 07:02
Harbormaster completed remote builds in B12765: Diff 23545.Sep 17 2020, 07:22
Fabien updated this revision to Diff 23546.Sep 17 2020, 08:33

Clean the log files

Fabien added a child revision: D7471: [CMAKE] Rename the man pages generation target.Sep 17 2020, 08:36
Harbormaster completed remote builds in B12766: Diff 23546.Sep 17 2020, 08:41
deadalnix requested changes to this revision.Sep 17 2020, 13:02
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/modules/InstallationHelper.cmake
184

None of this belongs here.

191

dito

Especially this one. This is a good indicator that once you've put things in the wrong place, you get more and more of it over time.

This revision now requires changes to proceed.Sep 17 2020, 13:02
Fabien planned changes to this revision.Sep 18 2020, 07:47
Fabien removed a parent revision: D7469: [CMAKE] Rename the test wrapper util.
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D7473: [CMAKE] Move the manpages generation logic to doc/man.
Fabien updated this revision to Diff 23577.Sep 18 2020, 07:58

Rebase on top of D7473.

Harbormaster completed remote builds in B12789: Diff 23577.Sep 18 2020, 08:12
deadalnix accepted this revision.Sep 18 2020, 23:00
This revision is now accepted and ready to land.Sep 18 2020, 23:00
Closed by commit rABCf571f9774071: [CMAKE] Silent the man pages generation (authored by Fabien). · Explain WhySep 21 2020, 14:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf571f9774071: [CMAKE] Silent the man pages generation.

Revision Contents
Changeset List

PathSize
cmake/
modules/
6 lines

Diff 23546

View Options

cmake/modules/InstallationHelper.cmake

Loading...