Page MenuHomePhabricator

[buildbot] Strip out commonly used separators when detecting backports in diff summaries
ClosedPublic

Authored by jasonbcox on Sep 18 2020, 18:32.

Details

Summary

We sometimes see variants like the following:

  • Backport of PR12345
  • Backport of PR 12345
  • Backport of PR#12345
  • Backport of PR #12345

Only the first one is automatically linked. We can detect these and both fix and link them
rather than ignoring them. The rationale for fixing them instead of leaving as-is is because
PRxxxxx is easier to grep if they are consistent in all patch summaries.

Other variants of the above are welcome. I simply picked these because we see them the most.

Test Plan

pytest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr-separators
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12804
Build 25681: Build Diffbuild-clang-10 · build-clang-tidy · build-without-wallet · build-diff
Build 25680: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Sep 18 2020, 23:19
deadalnix added a subscriber: deadalnix.

No. This makes history ungreppable.

This revision now requires changes to proceed.Sep 18 2020, 23:19

I don't think you read the summary. All of these variants are re-written to appear as the first variant, ensuring that these are both greppable and linked.

This revision is now accepted and ready to land.Sep 19 2020, 13:32