Page MenuHomePhabricator
Differential D7622

[backport#12951] [doc] Fix comment in FindForkInGlobalIndex
ClosedPublic
Actions

Authored by majcosta on Sep 28 2020, 20:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC96909c5381da: [backport#12951] [doc] Fix comment in FindForkInGlobalIndex
Summary

[doc] Fix comment in FindForkInGlobalIndex (James O'Beirne)

Pull request description:

The comment erroneously implies that we're searching `chainActive` for the
first block common to `locator`, but we're using the parameter `chain`.

Backport of Core PR12951

Test Plan
just read it

Diff Detail

Event Timeline

majcosta created this revision.Sep 28 2020, 20:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 20:17
majcosta requested review of this revision.Sep 28 2020, 20:17
teamcity edited the summary of this revision. (Show Details)Sep 28 2020, 20:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Sep 28 2020, 20:21
This revision is now accepted and ready to land.Sep 28 2020, 20:21
Harbormaster completed remote builds in B12993: Diff 23915.Sep 28 2020, 20:29
Closed by commit rABC96909c5381da: [backport#12951] [doc] Fix comment in FindForkInGlobalIndex (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhySep 28 2020, 20:31
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC96909c5381da: [backport#12951] [doc] Fix comment in FindForkInGlobalIndex.

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 23915

View Options

src/validation.cpp

Loading...