Page MenuHomePhabricator
Differential D7687

[backport#17371 2/2] Refactor: Require scriptPubKey to get wallet SigningProvider
ClosedPublic
Actions

Authored by majcosta on Sep 30 2020, 20:40.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC149452d5eee5: [backport#17371 2/2] Refactor: Require scriptPubKey to get wallet…
Summary

Easier to review ignoring whitespace:

git log -p -n1 -w

This commit does not change behavior. It passes new CScript arguments to
signing functions, but the arguments aren't currently used.

https://github.com/bitcoin/bitcoin/pull/17371/commits/d0dab897afaac0a18aa47d3ce673a4a43a69178a

Depends on D7686

Concludes backport of Core PR17371

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 30 2020, 20:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 20:40
majcosta requested review of this revision.Sep 30 2020, 20:40
teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 20:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13080: Diff 24072.Sep 30 2020, 20:53
jasonbcox accepted this revision.Sep 30 2020, 21:32
This revision is now accepted and ready to land.Sep 30 2020, 21:32
Closed by commit rABC149452d5eee5: [backport#17371 2/2] Refactor: Require scriptPubKey to get wallet… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhySep 30 2020, 22:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC149452d5eee5: [backport#17371 2/2] Refactor: Require scriptPubKey to get wallet….

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines
21 lines
qt/
3 lines
3 lines
wallet/
31 lines
64 lines
10 lines
26 lines

Diff 24072

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/signverifymessagedialog.cpp

Loading...
View Options

src/wallet/psbtwallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...