Paths

Table of Contentst

Differential D7746

[backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70)
ClosedPublic
Actions

Authored by majcosta on Oct 2 2020, 17:22.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCb3d60780c3a2: [backport#16554] test: only include and use OpenSSL where it's actually needed…

Summary

2f37163caf244acbe5fc715f2321aebc231522bc test: only include and init openSSL where it's actually used (fanquake)

Pull request description:

This should save initializing OpenSSL during tests if compiled with `--disable-bip70`.

Backport of Core PR16554

Test Plan

with -DENABLE_BIP70=[ON|OFF]:

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16554

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13164
Build 26378: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 26377: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 2 2020, 17:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 17:22

majcosta requested review of this revision.Oct 2 2020, 17:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13164: Diff 24221.Oct 2 2020, 17:33

You need to enable/disable BIP70 in the test plan.

src/qt/test/paymentservertests.cpp
18	These checks shouldn't be necessary. See `qt/test/CMakeLists.txt`

This revision now requires changes to proceed.Oct 2 2020, 18:16

you're right, no need for the preprocessor conditionals

Harbormaster completed remote builds in B13168: Diff 24225.Oct 2 2020, 18:40

jasonbcox accepted this revision.Oct 2 2020, 18:52

jasonbcox added inline comments.

src/qt/test/paymentservertests.cpp
19 ↗	(On Diff #24225)	errant newline

This revision is now accepted and ready to land.Oct 2 2020, 18:52

Closed by commit rABCb3d60780c3a2: [backport#16554] test: only include and use OpenSSL where it's actually needed… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyOct 2 2020, 18:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb3d60780c3a2: [backport#16554] test: only include and use OpenSSL where it's actually needed….

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

paymentservertests.cpp

10 lines

test_main.cpp

10 lines

Diff 24221

View Options

src/qt/test/paymentservertests.cpp